Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SqsPolicy from JustSaying #1139

Closed
Quazimon opened this issue Mar 8, 2023 · 0 comments · Fixed by #1144
Closed

Remove SqsPolicy from JustSaying #1139

Quazimon opened this issue Mar 8, 2023 · 0 comments · Fixed by #1144
Assignees

Comments

@Quazimon
Copy link

Quazimon commented Mar 8, 2023

I found that during the subscription creation we're rewritting Policy attribute. And this one is done in a very strict maner - all existing policy statements are being deleted. See usage here and implementation here.

The main thing is that we don't need this operation at all because inside IAmazonSimpleNotificationService.SubscribeQueueAsync is well implemented policy updater that will keep existing statements & add new based on the TopicArn. See the link to AWS SDK.

Suggested solution: remove custom policy updater from JustSaying because

  1. it's an unnecessary API call
  2. we don't want to override existing statements inside policy

Possible solution: allow JustSaying to set their custom policy over policy that is created via AWS SDK (but not override it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants