Support dynamic publishers #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1010 +/- ##
==========================================
+ Coverage 84.91% 84.92% +0.01%
==========================================
Files 132 135 +3
Lines 3228 3290 +62
==========================================
+ Hits 2741 2794 +53
- Misses 487 496 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
src/JustSaying/Fluent/PublishConfig/DynamicPublicationConfiguration.cs
Outdated
Show resolved
Hide resolved
src/JustSaying/Fluent/PublishConfig/DynamicPublicationConfiguration.cs
Outdated
Show resolved
Hide resolved
src/JustSaying/Fluent/PublishConfig/DynamicPublicationConfiguration.cs
Outdated
Show resolved
Hide resolved
src/JustSaying/Fluent/PublishConfig/DynamicPublicationConfiguration.cs
Outdated
Show resolved
Hide resolved
src/JustSaying/Fluent/PublishConfig/DynamicPublicationConfiguration.cs
Outdated
Show resolved
Hide resolved
src/JustSaying/Fluent/PublishConfig/StaticPublicationConfiguration.cs
Outdated
Show resolved
Hide resolved
src/JustSaying/Fluent/PublishConfig/DynamicPublicationConfiguration.cs
Outdated
Show resolved
Hide resolved
gkinsman
force-pushed
the
support-dynamic-publishers
branch
from
ebf9d5b to
20f9ce6
Compare
…fluent api a bit easier to read
…artup and late-bound topic publishers. - Make test pass (it fails sometimes for some reason still but let's agree on the shape)
- ConfigureAwait
…ublishes) - Add unique test id to each queue so tests are independent - Switch publisher cache to use concurrent dictionary to protect against reads if a publisher is being added by another thread.
…ell with shouldly
- Add xml docs for new API - Minor renames
- Publish second message to same topic to make sure that works - Add some more docs
Co-authored-by: Martin Costello <[email protected]>
Co-authored-by: Martin Costello <[email protected]>
Co-authored-by: Martin Costello <[email protected]>
Co-authored-by: Martin Costello <[email protected]>
Co-authored-by: Martin Costello <[email protected]>
Co-authored-by: Martin Costello <[email protected]>
Co-authored-by: Martin Costello <[email protected]>
Co-authored-by: Martin Costello <[email protected]>
…ation.cs Co-authored-by: Martin Costello <[email protected]>
Co-authored-by: Martin Costello <[email protected]>
…tion.cs Co-authored-by: Martin Costello <[email protected]>
gkinsman
force-pushed
the
support-dynamic-publishers
branch
from
f81ee99 to
b302636
Compare
added 2 commits
May 19, 2022 13:09
martincostello
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new mechanism to support publishing to tenanted topics using the solution outlined in #1004.
It adds a new
TopicPublicationBuilder<T> WithTopicName(Func<Message, string> topicNameCustomizer)overload toTopicPublicationBuilder<T>that allows users to dynamically create a topic at publish time instead of statically defining them on startup.