Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NuGet package for Microsoft DI #479

Merged
merged 2 commits into from
Dec 18, 2018
Merged

Add NuGet package for Microsoft DI #479

merged 2 commits into from
Dec 18, 2018

Conversation

martincostello
Copy link
Member

Add a new NuGet package to provide glue between JustSaying and Microsoft.Extensions.DependencyInjection.

This PR essentially just moves some code already added by #431 into its own NuGet package.

Resolves #474.

Add a new NuGet package to provide glue between JustSaying and Microsoft.Extensions.DependencyInjection.
Resolves #474.
Add a relevant package description.
@slang25
Copy link
Member

slang25 commented Dec 15, 2018

Very nice. Naming wise, I see a lot of other packages with just <blah>.Extensions.DependencyInjection, or if they include Microsoft it comes before the DI part. What's your thoughts on dropping Microsoft?

Just seen the other PR 🤦‍♂️

Copy link
Member

@slang25 slang25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@martincostello martincostello merged commit 692947f into justeattakeaway:master Dec 18, 2018
@martincostello martincostello deleted the issue-474-microsoft-di-extensions branch December 18, 2018 09:40
@tonymobster
Copy link

Can this package be published? Even as a pre-release? I really like the new builder API and want to use that on a new POC i'm about to start.

@martincostello
Copy link
Member Author

It’s a holiday here in the U.K. where the team are based until Tuesday, but we could discuss shipping an alpha to NuGet next week if people like yourself are interested in early access to parts of v7.0.0.

@tonymobster
Copy link

Sweet! That would be great. We're on holiday here until Tuesday too so next week is fine.

@tonymobster
Copy link

Has there been a decision on this?

@martincostello
Copy link
Member Author

Instead of us publishing an alpha to NuGet.org, you can configure a custom feed with the NuGet in our AppVeyor CI instead: https://ci.appveyor.com/nuget/justsaying-jhto5gatphuv

Hope that works OK for you.

@tonymobster
Copy link

Sure, that works for me. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NuGet package to bridge to Microsoft .NET Core DI
4 participants