Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize SourceRoot #923

Merged
merged 1 commit into from
Jun 30, 2021
Merged

Normalize SourceRoot #923

merged 1 commit into from
Jun 30, 2021

Conversation

martincostello
Copy link
Member

Use built-in property function to normalize the source root path.

Use built-in property function to normalize the source root path.
@martincostello martincostello requested a review from slang25 June 30, 2021 16:38
@martincostello martincostello requested a review from a team as a code owner June 30, 2021 16:38
@codecov
Copy link

codecov bot commented Jun 30, 2021

Codecov Report

Merging #923 (e8980c3) into main (36a1bbb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #923   +/-   ##
=======================================
  Coverage   84.19%   84.19%           
=======================================
  Files         120      120           
  Lines        3120     3120           
=======================================
  Hits         2627     2627           
  Misses        493      493           
Flag Coverage Δ
linux 84.19% <ø> (ø)
macos 52.96% <ø> (-0.04%) ⬇️
windows 52.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36a1bbb...e8980c3. Read the comment docs.

Copy link
Member

@slang25 slang25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one

@slang25 slang25 merged commit 028f506 into justeattakeaway:main Jun 30, 2021
@martincostello martincostello deleted the Normalize-Path branch June 30, 2021 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants