Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to MELT for testing logging #930

Merged
merged 3 commits into from
Aug 6, 2021
Merged

Switch to MELT for testing logging #930

merged 3 commits into from
Aug 6, 2021

Conversation

gkinsman
Copy link
Contributor

@gkinsman gkinsman commented Aug 3, 2021

Microsoft.Extensions.Logging.Testing aka MELT on nuget is a useful lib that captures logs and provides access to them in tests. It's also a lot more reliable to test than approvals as approvals rely on the order of output.

Other misc things:

  • Fix some issues with property values being types and not strings
  • Use FullName everywhere

- Fix some issues with property values being types and not strings
- Use FullName everywhere
@gkinsman gkinsman requested a review from a team as a code owner August 3, 2021 22:16
@gkinsman gkinsman requested a review from martincostello August 3, 2021 22:16
@codecov
Copy link

codecov bot commented Aug 3, 2021

Codecov Report

Merging #930 (891baac) into main (07afe4e) will increase coverage by 0.41%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #930      +/-   ##
==========================================
+ Coverage   84.19%   84.61%   +0.41%     
==========================================
  Files         120      120              
  Lines        3120     3120              
==========================================
+ Hits         2627     2640      +13     
+ Misses        493      480      -13     
Flag Coverage Δ
linux 84.48% <100.00%> (+0.28%) ⬆️
macos 53.13% <100.00%> (+0.53%) ⬆️
windows 52.99% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ools/MessageHandling/Dispatch/MessageDispatcher.cs 93.12% <100.00%> (+5.34%) ⬆️
...ng/AwsTools/MessageHandling/SnsMessagePublisher.cs 96.10% <100.00%> (ø)
...ng/AwsTools/MessageHandling/SqsMessagePublisher.cs 88.67% <100.00%> (ø)
...ng/Middleware/ExactlyOnce/ExactlyOnceMiddleware.cs 92.59% <0.00%> (+14.81%) ⬆️
...aying/Messaging/Monitoring/NullOpMessageMonitor.cs 90.00% <0.00%> (+20.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07afe4e...891baac. Read the comment docs.

martincostello
martincostello previously approved these changes Aug 4, 2021
slang25
slang25 previously approved these changes Aug 4, 2021
Copy link
Member

@slang25 slang25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@gkinsman gkinsman dismissed stale reviews from slang25 and martincostello via b153cd0 August 6, 2021 09:06
martincostello
martincostello previously approved these changes Aug 6, 2021
@martincostello
Copy link
Member

If this works then just need to rebase #929 once this is merged.

@gkinsman gkinsman merged commit f721b46 into justeattakeaway:main Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants