-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to MELT for testing logging #930
Conversation
- Fix some issues with property values being types and not strings - Use FullName everywhere
Codecov Report
@@ Coverage Diff @@
## main #930 +/- ##
==========================================
+ Coverage 84.19% 84.61% +0.41%
==========================================
Files 120 120
Lines 3120 3120
==========================================
+ Hits 2627 2640 +13
+ Misses 493 480 -13
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice
If this works then just need to rebase #929 once this is merged. |
Microsoft.Extensions.Logging.Testing aka MELT on nuget is a useful lib that captures logs and provides access to them in tests. It's also a lot more reliable to test than approvals as approvals rely on the order of output.
Other misc things: