Skip to content

Commit

Permalink
log(ingest/lookml): view file missing/parsing as warnings (datahub-pr…
Browse files Browse the repository at this point in the history
  • Loading branch information
skrydal authored Jan 28, 2025
1 parent 7870b13 commit 79aa40f
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,9 @@ def _get_generic_definition(
class LookerConnectionDefinition(ConfigModel):
platform: str
default_db: str
default_schema: Optional[str] # Optional since some sources are two-level only
default_schema: Optional[str] = (
None # Optional since some sources are two-level only
)
platform_instance: Optional[str] = None
platform_env: Optional[str] = Field(
default=None,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ def _load_viewfile(
with open(path) as file:
raw_file_content = file.read()
except Exception as e:
self.reporter.failure(
self.reporter.report_warning(
title="LKML File Loading Error",
message="A lookml file is not present on local storage or GitHub",
context=f"file path: {path}",
Expand Down Expand Up @@ -101,7 +101,7 @@ def _load_viewfile(
self.viewfile_cache[path] = looker_viewfile
return looker_viewfile
except Exception as e:
self.reporter.failure(
self.reporter.report_warning(
title="LKML File Parsing Error",
message="The input file is not lookml file",
context=f"file path: {path}",
Expand Down

0 comments on commit 79aa40f

Please sign in to comment.