Support astral ID_Continue characters in capture group names #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 6 | ||
| ], | ||
| "raw": "$𐒤" | ||
| } |
There was a problem hiding this comment.
Maybe add a few more tests? Here are some more examples of differences between ES5 and ES2015+ identifiers: https://mathiasbynens.be/notes/javascript-identifiers-es6
There was a problem hiding this comment.
I added another test for two of these differences.
|
@adrianheine, thanks for providing this addressing the review comments of @mathiasbynens! |
|
@adrianheine, do you have a patch coming up soon like with the last version? If not, I would release a new version, otherwise consider waiting for a new PR to land. |
|
I think that's it for now :) |
|
Published v0.6.0 to npm and added a new release: https://github.com/jviereck/regjsparser/releases/tag/v0.6.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #90.