PR-root-completion - initial completion #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #33 +/- ##
==========================================
+ Coverage 85.42% 86.23% +0.81%
==========================================
Files 13 13
Lines 2394 2420 +26
==========================================
+ Hits 2045 2087 +42
+ Misses 255 241 -14
+ Partials 94 92 -2 ☔ View full report in Codecov by Sentry. |
Change-Id: I1abe605198c025dfc5fd57aea0cf53686506e4b7
…letion function of root, flags broken on it
…, root suggestion, flags on root no
|
@jxskiss Could you please review code? |
|
@akemrir Sure, will do review in the following two days. |
|
LGTM. Thank you for the effor on this feature 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is start of completion for root command. Not working fully.