[MySQL]Fix constraints/indexes detection bug

- When FK and UNIQUE are assigned to the same column - When PRIMARY KEY and UNIQUE are assigned to the same column
k1LoW · Feb 17, 2020 · 0ccde33 · 0ccde33
1 parent 91afe4b
commit 0ccde33
Show file tree

Hide file tree

Showing 6 changed files with 18 additions and 5 deletions.
diff --git a/drivers/mysql/mysql.go b/drivers/mysql/mysql.go
@@ -161,11 +161,11 @@ LEFT JOIN
    kcu.table_name,
    kcu.constraint_name,
    kcu.column_name,
-   (CASE WHEN c.column_key='PRI' AND kcu.referenced_table_name IS NULL THEN 'PRIMARY KEY'
-        WHEN c.column_key='UNI' THEN 'UNIQUE'
-        WHEN c.column_key='MUL' AND kcu.referenced_table_name IS NULL THEN 'UNIQUE'
-        WHEN c.column_key='MUL' AND kcu.referenced_table_name IS NOT NULL THEN 'FOREIGN KEY'
-        WHEN c.column_key='PRI' AND kcu.referenced_table_name IS NOT NULL THEN 'FOREIGN KEY'
+   (CASE WHEN kcu.referenced_table_name IS NOT NULL THEN 'FOREIGN KEY'
+        WHEN c.column_key = 'PRI' AND kcu.constraint_name = 'PRIMARY' THEN 'PRIMARY KEY'
+        WHEN c.column_key = 'PRI' AND kcu.constraint_name != 'PRIMARY' THEN 'UNIQUE'
+        WHEN c.column_key = 'UNI' THEN 'UNIQUE'
+        WHEN c.column_key = 'MUL' THEN 'UNIQUE'
         ELSE 'UNKNOWN'
    END) AS costraint_type
    FROM information_schema.key_column_usage AS kcu

diff --git a/sample/exclude/user_options.md b/sample/exclude/user_options.md
@@ -14,6 +14,7 @@ CREATE TABLE `user_options` (
   `created` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP,
   `updated` timestamp NOT NULL DEFAULT '0000-00-00 00:00:00',
   PRIMARY KEY (`user_id`),
+  UNIQUE KEY `user_id` (`user_id`),
   CONSTRAINT `user_options_user_id_fk` FOREIGN KEY (`user_id`) REFERENCES `users` (`id`) ON DELETE CASCADE ON UPDATE NO ACTION
 ) ENGINE=InnoDB DEFAULT CHARSET=latin1 COMMENT='User options table'
 ```
@@ -34,13 +35,15 @@ CREATE TABLE `user_options` (
 | Name | Type | Definition |
 | ---- | ---- | ---------- |
 | PRIMARY | PRIMARY KEY | PRIMARY KEY (user_id) |
+| user_id | UNIQUE | UNIQUE KEY user_id (user_id) |
 | user_options_user_id_fk | FOREIGN KEY | FOREIGN KEY (user_id) REFERENCES users (id) |
 
 ## Indexes
 
 | Name | Definition |
 | ---- | ---------- |
 | PRIMARY | PRIMARY KEY (user_id) USING BTREE |
+| user_id | UNIQUE KEY user_id (user_id) USING BTREE |
 
 ## Relations
 

diff --git a/sample/mysql/user_options.md b/sample/mysql/user_options.md
@@ -14,6 +14,7 @@ CREATE TABLE `user_options` (
   `created` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP,
   `updated` timestamp NOT NULL DEFAULT '0000-00-00 00:00:00',
   PRIMARY KEY (`user_id`),
+  UNIQUE KEY `user_id` (`user_id`),
   CONSTRAINT `user_options_user_id_fk` FOREIGN KEY (`user_id`) REFERENCES `users` (`id`) ON DELETE CASCADE ON UPDATE NO ACTION
 ) ENGINE=InnoDB DEFAULT CHARSET=latin1 COMMENT='User options table'
 ```
@@ -34,13 +35,15 @@ CREATE TABLE `user_options` (
 | Name | Type | Definition |
 | ---- | ---- | ---------- |
 | PRIMARY | PRIMARY KEY | PRIMARY KEY (user_id) |
+| user_id | UNIQUE | UNIQUE KEY user_id (user_id) |
 | user_options_user_id_fk | FOREIGN KEY | FOREIGN KEY (user_id) REFERENCES users (id) |
 
 ## Indexes
 
 | Name | Definition |
 | ---- | ---------- |
 | PRIMARY | PRIMARY KEY (user_id) USING BTREE |
+| user_id | UNIQUE KEY user_id (user_id) USING BTREE |
 
 ## Relations
 

diff --git a/sample/mysql8/user_options.md b/sample/mysql8/user_options.md
@@ -14,6 +14,7 @@ CREATE TABLE `user_options` (
   `created` timestamp NOT NULL,
   `updated` timestamp NULL DEFAULT NULL,
   PRIMARY KEY (`user_id`),
+  UNIQUE KEY `user_id` (`user_id`),
   CONSTRAINT `user_options_user_id_fk` FOREIGN KEY (`user_id`) REFERENCES `users` (`id`) ON DELETE CASCADE
 ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_0900_ai_ci COMMENT='User options table'
 ```
@@ -34,13 +35,15 @@ CREATE TABLE `user_options` (
 | Name | Type | Definition |
 | ---- | ---- | ---------- |
 | PRIMARY | PRIMARY KEY | PRIMARY KEY (user_id) |
+| user_id | UNIQUE | UNIQUE KEY user_id (user_id) |
 | user_options_user_id_fk | FOREIGN KEY | FOREIGN KEY (user_id) REFERENCES users (id) |
 
 ## Indexes
 
 | Name | Definition |
 | ---- | ---------- |
 | PRIMARY | PRIMARY KEY (user_id) USING BTREE |
+| user_id | UNIQUE KEY user_id (user_id) USING BTREE |
 
 ## Relations
 

diff --git a/sample/svg/user_options.md b/sample/svg/user_options.md
@@ -14,6 +14,7 @@ CREATE TABLE `user_options` (
   `created` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP,
   `updated` timestamp NOT NULL DEFAULT '0000-00-00 00:00:00',
   PRIMARY KEY (`user_id`),
+  UNIQUE KEY `user_id` (`user_id`),
   CONSTRAINT `user_options_user_id_fk` FOREIGN KEY (`user_id`) REFERENCES `users` (`id`) ON DELETE CASCADE ON UPDATE NO ACTION
 ) ENGINE=InnoDB DEFAULT CHARSET=latin1 COMMENT='User options table'
 ```
@@ -34,13 +35,15 @@ CREATE TABLE `user_options` (
 | Name | Type | Definition |
 | ---- | ---- | ---------- |
 | PRIMARY | PRIMARY KEY | PRIMARY KEY (user_id) |
+| user_id | UNIQUE | UNIQUE KEY user_id (user_id) |
 | user_options_user_id_fk | FOREIGN KEY | FOREIGN KEY (user_id) REFERENCES users (id) |
 
 ## Indexes
 
 | Name | Definition |
 | ---- | ---------- |
 | PRIMARY | PRIMARY KEY (user_id) USING BTREE |
+| user_id | UNIQUE KEY user_id (user_id) USING BTREE |
 
 ## Relations
 

diff --git a/testdata/my.sql b/testdata/my.sql
@@ -23,6 +23,7 @@ CREATE TABLE user_options (
   show_email boolean NOT NULL DEFAULT false,
   created timestamp NOT NULL,
   updated timestamp,
+  UNIQUE(user_id),
   CONSTRAINT user_options_user_id_fk FOREIGN KEY(user_id) REFERENCES users(id) ON UPDATE NO ACTION ON DELETE CASCADE
 ) COMMENT = 'User options table';