Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for MS SQL Server #118

Merged
merged 18 commits into from
Jun 3, 2019
Merged

Support for MS SQL Server #118

merged 18 commits into from
Jun 3, 2019

Conversation

k1LoW
Copy link
Owner

@k1LoW k1LoW commented Jun 1, 2019

link #117

@k1LoW k1LoW added the enhancement New feature or request label Jun 1, 2019
@k1LoW k1LoW self-assigned this Jun 1, 2019
@k1LoW k1LoW changed the title Support MS SQL Server Support for MS SQL Server Jun 1, 2019
@codecov
Copy link

codecov bot commented Jun 1, 2019

Codecov Report

Merging #118 into master will increase coverage by 1.76%.
The diff coverage is 83.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #118      +/-   ##
==========================================
+ Coverage   70.84%   72.61%   +1.76%     
==========================================
  Files          12       12              
  Lines        2168     2509     +341     
==========================================
+ Hits         1536     1822     +286     
- Misses        486      521      +35     
- Partials      146      166      +20
Impacted Files Coverage Δ
datasource/datasource.go 55.08% <100%> (+1.17%) ⬆️
drivers/mssql/mssql.go 83.54% <83.54%> (ø)
drivers/bq/bq.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3798f21...e77e950. Read the comment docs.

@k1LoW k1LoW marked this pull request as ready for review June 3, 2019 14:52
@k1LoW k1LoW merged commit 8f30f37 into master Jun 3, 2019
@k1LoW k1LoW deleted the mssql branch June 3, 2019 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant