Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Dockerfile #136

Merged
merged 2 commits into from
Aug 19, 2019
Merged

add Dockerfile #136

merged 2 commits into from
Aug 19, 2019

Conversation

peccu
Copy link
Contributor

@peccu peccu commented Aug 19, 2019

Thank you for making cool tool for DB.
I think this tool is useful with docker, so I wrote simple Dockerfile.

with README.md updated, but it should work after docker hub configuration.
( Why the tag k1low/tbls is lowercase that is because from docker's restriction invalid reference format: repository name must be lowercase.)

You can use in docker-compose.yml too like this.

version: '3.7'
services:
  tbls:
    # from docker hub
    # image: k1low/tbls

    # from current docker/Dockerfile
    build: ./docker

    depends_on:
      - db_service
    volumes:
      - .:/work
    command: "doc postgres://dbuser:dbpass@db_service:5432/dbname"

@codecov
Copy link

codecov bot commented Aug 19, 2019

Codecov Report

Merging #136 into master will decrease coverage by 1.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
- Coverage    69.4%   68.22%   -1.19%     
==========================================
  Files          12       12              
  Lines        2618     2618              
==========================================
- Hits         1817     1786      -31     
- Misses        616      653      +37     
+ Partials      185      179       -6
Impacted Files Coverage Δ
datasource/datasource.go 20.85% <0%> (-19.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 527fae6...6cc0e17. Read the comment docs.

@k1LoW k1LoW self-assigned this Aug 19, 2019
@k1LoW
Copy link
Owner

k1LoW commented Aug 19, 2019

@peccu !!! Great! Thank you for your commit !!!

but it should work after docker hub configuration

OK!!

@k1LoW k1LoW merged commit c733287 into k1LoW:master Aug 19, 2019
@k1LoW
Copy link
Owner

k1LoW commented Aug 19, 2019

Create https://hub.docker.com/r/k1low/tbls !

@peccu
Copy link
Contributor Author

peccu commented Aug 19, 2019

Thank you for merging and configuring docker hub 👏

@peccu peccu deleted the dockerfile branch August 19, 2019 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants