Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add error handling #137

Merged
merged 1 commit into from
Sep 5, 2019
Merged

add error handling #137

merged 1 commit into from
Sep 5, 2019

Conversation

toshi0607
Copy link
Contributor

  • I'd like to add and fix error handlings.
  • Great OSS! I tried Spanner one.

toshi0607
toshi0607 commented Sep 5, 2019
View reviewed changes
cmd/out.go
printError(err)
t, ferr := s.FindTableByName(tableName)
if ferr != nil {
printError(ferr)
os.Exit(1)
}
err = o.OutputTable(wr, t)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This err is L121 one without this change.

@codecov
Copy link

codecov bot commented Sep 5, 2019 •
edited
Loading

Codecov Report

Merging #137 into master will decrease coverage by 1.34%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #137      +/-   ##
==========================================
- Coverage    69.4%   68.06%   -1.35%     
==========================================
  Files          12       12              
  Lines        2618     2624       +6     
==========================================
- Hits         1817     1786      -31     
- Misses        616      657      +41     
+ Partials      185      181       -4
Impacted Files Coverage Δ
drivers/sqlite/sqlite.go 85.86% <0%> (-1.38%) ⬇️
datasource/datasource.go 20.85% <0%> (-19.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c733287...05ae881. Read the comment docs.

@k1LoW
Copy link
Owner

k1LoW commented Sep 5, 2019

Hi @toshi0607 ! Thank you for your fix !!

I tried Spanner one.

WOW ! GREAT ! THANK YOU !

@k1LoW k1LoW merged commit 8ae6fc2 into k1LoW:master Sep 5, 2019
@toshi0607 toshi0607 deleted the feature/add-error-handling branch September 6, 2019 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@toshi0607 @k1LoW