Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lint rule requireForeignKeyIndex #142

Merged
merged 6 commits into from
Nov 2, 2019
Merged

Add lint rule requireForeignKeyIndex #142

merged 6 commits into from
Nov 2, 2019

Conversation

k1LoW
Copy link
Owner

@k1LoW k1LoW commented Nov 2, 2019

# .tbls.yml
lint:
  requireForeignKeyIndex:
    enabled: true
    exclude:
      - comments.user_id

@k1LoW k1LoW self-assigned this Nov 2, 2019
@codecov
Copy link

codecov bot commented Nov 2, 2019

Codecov Report

Merging #142 into master will decrease coverage by 0.78%.
The diff coverage is 68.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #142      +/-   ##
==========================================
- Coverage   69.32%   68.53%   -0.79%     
==========================================
  Files          12       12              
  Lines        2657     2708      +51     
==========================================
+ Hits         1842     1856      +14     
- Misses        624      661      +37     
  Partials      191      191
Impacted Files Coverage Δ
schema/schema.go 44.61% <ø> (ø) ⬆️
drivers/mssql/mssql.go 82.87% <ø> (ø) ⬆️
drivers/sqlite/sqlite.go 85.86% <100%> (ø) ⬆️
drivers/mysql/mysql.go 81.99% <100%> (+0.05%) ⬆️
drivers/postgres/postgres.go 70.76% <100%> (ø) ⬆️
config/lint.go 88.37% <66.66%> (-0.16%) ⬇️
datasource/datasource.go 20.85% <0%> (-19.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb4f451...94ddb65. Read the comment docs.

@k1LoW k1LoW marked this pull request as ready for review November 2, 2019 07:00
@k1LoW k1LoW added the enhancement New feature or request label Nov 2, 2019
@k1LoW k1LoW merged commit ecad53d into master Nov 2, 2019
@k1LoW k1LoW deleted the require-fk-index branch November 2, 2019 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant