Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint rule requireColumnComment excludes table_name.column_name as well as column_name #143

Merged
merged 1 commit into from
Nov 2, 2019

Conversation

k1LoW
Copy link
Owner

@k1LoW k1LoW commented Nov 2, 2019

No description provided.

@k1LoW k1LoW self-assigned this Nov 2, 2019
@codecov
Copy link

codecov bot commented Nov 2, 2019

Codecov Report

Merging #143 into master will decrease coverage by 0.66%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #143      +/-   ##
==========================================
- Coverage   69.68%   69.01%   -0.67%     
==========================================
  Files          12       12              
  Lines        2708     2711       +3     
==========================================
- Hits         1887     1871      -16     
- Misses        624      653      +29     
+ Partials      197      187      -10
Impacted Files Coverage Δ
config/lint.go 95.42% <100%> (+7.05%) ⬆️
datasource/datasource.go 20.85% <0%> (-19.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecad53d...074f883. Read the comment docs.

@k1LoW k1LoW merged commit c0fb473 into master Nov 2, 2019
@k1LoW k1LoW deleted the lint-exclude-column-using-table-name branch November 2, 2019 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant