call dot command with temporary file , graph name in dot file must be quoted #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenichiro-kimura
commented
Jun 4, 2018
kenichiro-kimura
commented
- for FreeBSD-amd64, the dot command must be called with temporary file, not with pipe and stdin
- in dot file, the graph name must be quoted( to use '-' in graph name)
…ile, not with pipe and stdin 2. in dot file, the graph name must be quoted( to use '-' in graph name)
k1LoW
requested changes
Jun 4, 2018
There was a problem hiding this comment.
Hi @kenichiro-kimura !! Thank you for your NICE COMMIT ! Could you check my comment ?
cmd/templates.go
Outdated
| @@ -0,0 +1,29 @@ | |||
| package dot | |||
There was a problem hiding this comment.
Could you remove this file ? ( may be unnecessary )
There was a problem hiding this comment.
Oh,sorry.. I removed the file. Thanks!
|
Thank you!!! 👍 |
k1LoW
added a commit
that referenced
this pull request
Jun 5, 2018
k1LoW
added a commit
that referenced
this pull request
Mar 9, 2019
call dot command with temporary file , graph name in dot file must be quoted
k1LoW
added a commit
that referenced
this pull request
Mar 9, 2019
k1LoW
added a commit
that referenced
this pull request
Apr 25, 2019
call dot command with temporary file , graph name in dot file must be quoted
k1LoW
added a commit
that referenced
this pull request
Apr 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.