-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Snowflake #267
Support Snowflake #267
Conversation
This is an initial implementation. So we do not implement about constraints information yet.
Codecov Report
@@ Coverage Diff @@
## master #267 +/- ##
==========================================
- Coverage 68.72% 67.37% -1.36%
==========================================
Files 23 23
Lines 3831 3859 +28
==========================================
- Hits 2633 2600 -33
- Misses 940 1005 +65
+ Partials 258 254 -4
Continue to review full report at Codecov.
|
@kanata2 GREAT WORK!!!!! Thank you!!!!!
I'm not able to have a persistent test environment for snowflake as well as you. If I put snowflake support in tbls, is it ok to make it "experimental support"? Also, is it possible to commit the following files? |
Thank you!
I think it's good. Thank you for your consideration 🙏 🙏
Okay, I'll add these files later. |
Hi @kanata2
If you have access to |
Ah, it's good idea! |
I'm sorry. |
@kanata2 |
Just added DDL and output files in 9ccbb93. |
@kanata2 Thank you for your great commit!! |
This is an initial implementation for Snowflake.
(If snowflake support is not needed for tbls, please close this PR 🙏 )
Note
I'm not sure what to do with the testing environment.
So I don't add test cases to snowflake driver yet.
Demo
The following is DDLs and configurations.
TBLS_SAMPLE.md
# TBLS_SAMPLEDescription
Table Definition
Columns
Relations