Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work with redshift #29

Merged
merged 2 commits into from
Jun 28, 2018
Merged

Work with redshift #29

merged 2 commits into from
Jun 28, 2018

Conversation

watarukura
Copy link

#26

Amazon Redshift can't use "'table_name'.regclass::oid".
Use "pg_catalog.pg_class" table, instead of it.

Test result of "TestAnalyzeView".

=== RUN   TestAnalyzeView
--- PASS: TestAnalyzeView (0.13s)
PASS
coverage: 85.8% of statements
ok      github.com/watarukura/tbls/drivers/postgres     0.145s  coverage: 85.8% of statements

@k1LoW k1LoW added the enhancement New feature or request label Jun 28, 2018
@k1LoW
Copy link
Owner

k1LoW commented Jun 28, 2018

Hi @watarukura !!! Thank you for your GREAT commit !!! LGTM !!!

@k1LoW k1LoW merged commit 501bcb3 into k1LoW:master Jun 28, 2018
@k1LoW
Copy link
Owner

k1LoW commented Jun 28, 2018

Released as v0.9.0.

k1LoW added a commit that referenced this pull request Mar 9, 2019
@k1LoW
Merge pull request #29 from watarukura/work_with_redshift
8bfeec1 
Work with redshift
k1LoW added a commit that referenced this pull request Apr 25, 2019
@k1LoW
Merge pull request #29 from watarukura/work_with_redshift
0c9fe18 
Work with redshift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@watarukura @k1LoW