Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling empty env vars in strict mode #293

Merged
merged 1 commit into from
Feb 4, 2021

Conversation

navaneeth-spotnana
Copy link
Contributor

We use set -o nounset and this is causing the quick install script to fail:

/tmp/use-tbls.tmp: line 21: TBLS_TMPDIR: unbound variable

Solution: https://stackoverflow.com/a/11264114/3073656

@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #293 (0b4d391) into master (ec213c5) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #293      +/-   ##
==========================================
- Coverage   66.51%   66.43%   -0.08%     
==========================================
  Files          25       25              
  Lines        4097     4097              
==========================================
- Hits         2725     2722       -3     
- Misses       1089     1091       +2     
- Partials      283      284       +1     
Impacted Files Coverage Δ
datasource/datasource.go 40.14% <0.00%> (-2.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec213c5...0b4d391. Read the comment docs.

@k1LoW
Copy link
Owner

k1LoW commented Feb 4, 2021

@navaneeth-spotnana Nice!! Thank you for your commitment!!!

@k1LoW k1LoW merged commit e23f43f into k1LoW:master Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants