Add PostgreSQL SSL mode in README.md #309
Conversation
README.md
Outdated
| @@ -61,6 +61,12 @@ Using docker image. | |||
| $ docker run --rm -v $PWD:/work k1low/tbls doc postgres://dbuser:dbpass@hostname:5432/dbname | |||
| ``` | |||
|
|
|||
| In SSL mode, add "?sslmode=disable" | |||
There was a problem hiding this comment.
I think you need to disable ssl mode when the PostgreSQL server does not support SSL connections.
There was a problem hiding this comment.
Sorry, I didn't explain enough.
I just would like you to add this statement, not replace.
So, This is what I meant.
Before:
After:
But, I made a mistake first pull request.
I'm sorry for confusing you.
I tried to add the statement under PostgreSQL connection.
But, first pull request has an error, I added the statement under Quick Start.
So, I fixed it and sent you pull request again.
There was a problem hiding this comment.
Why In SSL mode, add "?sslmode=disable" ?
SSL mode is a connection method between client and server. It is not a setting that should always be disabled.
There was a problem hiding this comment.
Sorry, my phrasing was bad.
I will rephrase it.
Before:
In SSL mode, add "?sslmode=disable"
After:
When you want to disable SSL mode, add "?sslmode=disable"
|
@kakisoft Thank you!! |
Codecov Report
@@ Coverage Diff @@
## master #309 +/- ##
==========================================
+ Coverage 66.39% 66.71% +0.32%
==========================================
Files 25 26 +1
Lines 4115 4287 +172
==========================================
+ Hits 2732 2860 +128
- Misses 1098 1134 +36
- Partials 285 293 +8
Continue to review full report at Codecov.
|
|
Thank you! |
In README, there is no statement about PostgreSQL in SSL mode.
So, I would like to suggest to add it.
Refer to:
#300