Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #338
There are 2 issues in the PR that an advise is needed :) Could you please help me with that? Thank you in advance for the help.
Encode func is used from mdurl. It is archived repository without activity. And it seems only encode functionality is required to fix the original issue. So the code was copy-pasted. Would it be better to import the whole
mdurl
package instead of the selected approach?Existing test TestOutput has been updated to check the case with a space in a table name. Would it be better to create a completely separate test for such case?
Thank you.