Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Add explanation for hide_auto_increment option #350

Merged
merged 1 commit into from
Apr 22, 2022

Conversation

tk0miya
Copy link
Contributor

@tk0miya tk0miya commented Apr 21, 2022

It was added in #277. But it've never described in the README. This
adds an explanation for hide_auto_increment option.

Thank you for creating such a wonderful tool :-)

It was added in k1LoW#277. But it've never described in the README.  This
adds an explanation for `hide_auto_increment` option.
@tk0miya
Copy link
Contributor Author

tk0miya commented Apr 21, 2022

Personally, it would be better to change this option enabled by default. I believe nobody will not get any information from AUTO_INCREMENT=[Redacted by tbls]. So I prefer to hide it by default and show it via option.

If you like to change this behavior, it would be better not to merge this. Because it's still a secret option.

@k1LoW
Copy link
Owner

k1LoW commented Apr 21, 2022

Thank you for adding the documentation!

Personally, it would be better to change this option enabled by default.

Thank you for your feedback.

I think it would be better to have a default state that first shows the fact that tbls is redacting AUTO_INCREMENT information.
Then, those who want to hide it can enable the hide_auto_increment option, and those who want to show it can enable the show_auto_increment option.

@k1LoW
Copy link
Owner

k1LoW commented Apr 21, 2022

So I want to merge this PR. how do you think about it?

@tk0miya
Copy link
Contributor Author

tk0miya commented Apr 21, 2022

I'm not sure how AUTO_INCREMENT information is useful. So I'd like to vote to change the default behavior. But I'm follow your decision because we've already had this option :-)

@k1LoW
Copy link
Owner

k1LoW commented Apr 22, 2022

Thank you !!!

@k1LoW k1LoW merged commit 6edee86 into k1LoW:main Apr 22, 2022
@tk0miya tk0miya deleted the hide_auto_increment branch April 23, 2022 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants