Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support service account impersonation with BigQuery #363

Merged
merged 1 commit into from
Jul 28, 2022

Conversation

k1LoW
Copy link
Owner

@k1LoW k1LoW commented Jul 28, 2022

ref: #360

@k1LoW k1LoW self-assigned this Jul 28, 2022
@github-actions
Copy link
Contributor

Code Metrics Report

main (072711d) #363 (ba224b5) +/-
Coverage 67.2% 64.7% -2.5%
Code to Test Ratio 1:0.5 1:0.5 -0.0
Test Execution Time 3m1s 2m20s -41s
Details
  |                     | main (072711d) | #363 (ba224b5) |  +/-  |
  |---------------------|----------------|----------------|-------|
- | Coverage            |          67.2% |          64.7% | -2.5% |
  |   Files             |             33 |             33 |     0 |
  |   Lines             |           3160 |           3171 |   +11 |
- |   Covered           |           2123 |           2051 |   -72 |
- | Code to Test Ratio  |          1:0.5 |          1:0.5 |  -0.0 |
  |   Code              |           8236 |           8250 |   +14 |
  |   Test              |           3887 |           3887 |     0 |
+ | Test Execution Time |           3m1s |          2m20s |  -41s |

Code coverage of files in pull request scope (38.6% → 10.6%)

Files Coverage +/-
datasource/gcp.go 10.6% -27.9%

Reported by octocov

@k1LoW k1LoW merged commit e4ff861 into main Jul 28, 2022
@k1LoW k1LoW deleted the bigquery-impersonate-service-account branch July 28, 2022 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant