[ENHANCEMENT] Add config processing and fix hostmode (#477, @konradmalik) #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwilltry42
approved these changes
Feb 9, 2021
iwilltry42
reviewed
Feb 9, 2021
iwilltry42
changed the title
rancherio-gh-m
pushed a commit
that referenced
this pull request
Feb 9, 2021
Author: Konrad Malik <[email protected]> Date: Tue Feb 9 15:17:58 2021 +0100 [ENHANCEMENT] Add config processing and fix hostmode (#477, @konradmalik)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this turned out to be larger than I though but let me know what you think.
I fixed the issue with api port mentioned here: #471, now the k3s value is mapped.
While doing that I noticed it is not so straightforward to find a place to make such a fix, as config is modified, transformed merged etc. and later those values are propagated as labels on containers. It can easily become a hack that would be inconsistent with the rest of the configurations, not an actual fix.
What I propose here is to add another step right after transforming the config:
ProcessClusterConfig, that would be responsible only for such "last step" config modifications like all the stuff for the "host" network: fixing api port, disabling docker host ip injection (my previous PR) or disabling load balancer. I already moved this stuff there. I guess the processing won't stop at that and soon more needed modifications for config will be found that can be put there for easier maintenance.Let me know if this is a good idea.