Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for KubeAPI Port assignment when using config files (#490, @dtomasi) #490

Merged
merged 3 commits into from
Feb 9, 2021

Conversation

dtomasi
Copy link
Collaborator

@dtomasi dtomasi commented Feb 9, 2021

Closes #462

Copy link
Member

@iwilltry42 iwilltry42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution :)

@iwilltry42 iwilltry42 changed the title Fix for KubeAPI Port assignment when using config files Fix for KubeAPI Port assignment when using config files (#490, @dtomasi) Feb 9, 2021
@iwilltry42 iwilltry42 merged commit dbfaeb4 into k3d-io:main Feb 9, 2021
rancherio-gh-m pushed a commit that referenced this pull request Feb 9, 2021
Author: Dominik Tomasi <[email protected]>
Date:   Tue Feb 9 15:47:17 2021 +0100

    Fix for KubeAPI Port assignment when using config files (#490, @dtomasi)
@dtomasi dtomasi deleted the fix-api-port-assignment branch February 9, 2021 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Cobra default values are overwriting settings in config file
2 participants