set vlan to 0 if not defined. #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinkennelly
approved these changes
Apr 19, 2021
|
A couple of nits in the commit message:
CNi -> CNI
tot -> to |
README.md
Outdated
| @@ -141,6 +141,10 @@ The below config will configure a VF using a userspace driver (uio/vfio) for use | |||
|
|
|||
| **Note** [DHCP](https://github.com/containernetworking/plugins/tree/master/plugins/ipam/dhcp) IPAM plugin can not be used for VF bound to a dpdk driver (uio/vfio). | |||
|
|
|||
| **Note** When VLAN is not specified in the Network-Attachment-Definition, or when it is given a value of 0, | |||
| VFs connected tho this network will have no vlan tag. | |||
It is more common that when no vlan tag is specified, the interface will have no vlan at all. The sriov-CNI acts differtly, and when a NAD is not configured with vlan, the VF will keep it's old vlan tag. This behavior is not "natural" and could cause confusion. This commit makes SRIOV-CNI treat no-vlan as zero vlan, which will effectively remove the vlan tag from the VF. To prevent future misunderstandings a note is added to the README about the new behavior. Signed-off-by: alonsadan <[email protected]>
alonSadan
force-pushed
the
remove_vlan_from_vf_when_no_vlan_on_nad
branch
from
a36a14d to
fe8eed9
Compare
Thanks for the review. |
adrianchiris
approved these changes
Apr 20, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is more common that when no vlan tag is specified,
the interface will have no vlan at all.
The sriov-CNI acts differtly, and when a NAD is not configured with
vlan, the VF will keep it's old vlan tag. This behaviour
is not "natural" and could cause confusion.
This commit makes SRIOV-CNi treat no-valn as zero vlan,
which will effectively remove the vlan tag from the VF.
To prevent future misunderstandings a note is added tot the README
about the new behavior.
Signed-off-by: alonsadan [email protected]