Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs/stream.flow #4

Merged
merged 7 commits into from
Aug 28, 2017
Merged

Bugs/stream.flow #4

merged 7 commits into from
Aug 28, 2017

Conversation

hthetiot
Copy link
Contributor

@hthetiot hthetiot commented Aug 28, 2017

SETTINGS frame may update SETTINGS_INITIAL_WINDOW_SIZE that affects
new stream window. For example, if SETTINGS_INITIAL_WINDOW_SIZE = 0,
initial DATA frames for new streams were going through to the peer
even though there is no stream window.

The fix is to adjust initial stream window for the newly created
streams.

Looks like `_allocateId` is deferred until first stream usage to make sure new stream ids are ordered correctly, but that was too late to properly honor the server-specified initial stream window negotiated during `SETTINGS` handshake.

Moving the notification of new stream earlier to pick up the server-specified initial stream window looks good to me.

jitsni and others added 7 commits August 22, 2017 15:44
@hthetiot hthetiot added the bug label Aug 28, 2017
@hthetiot hthetiot requested a review from jfallows August 28, 2017 19:07
@hthetiot hthetiot added this to the v4.0.x milestone Aug 28, 2017
@hthetiot hthetiot changed the base branch from master to develop August 28, 2017 19:07
@hthetiot hthetiot merged commit 7c717b3 into develop Aug 28, 2017
@hthetiot hthetiot deleted the bugs/stream.flow branch July 13, 2018 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants