4.0.6: Object.prototype methods will not ruin the result any more

kaelzhang · Aug 12, 2018 · 56976ce · 56976ce
1 parent babc421
commit 56976ce
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 4 deletions.
diff --git a/.gitignore b/.gitignore
@@ -40,9 +40,9 @@ package-lock.json
 .tmproj
 *.esproj
 *.sublime-project
-*.sublime-workspace
 nbproject
 thumbs.db
+*.*-workspace
 
 # Folders to ignore
 .hg

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -13,3 +13,7 @@
 ## ~ 2018-08-09, Version 4.0.1 - 4.0.5
 
 - **PATCH**: updates README.md about frequent asked quesions from github issues.
+
+## 2018-08-12, Version 4.0.6
+
+- **PATCH**: `Object.prototype` methods will not ruin the result any more.
diff --git a/index.js b/index.js
@@ -265,7 +265,7 @@ const NEGATIVE_REPLACERS = [
 ]
 
 // A simple cache, because an ignore rule only has only one certain meaning
-const cache = {}
+const cache = Object.create(null)
 
 // @param {pattern}
 const make_regex = (pattern, negative, ignorecase) => {
@@ -335,7 +335,7 @@ class IgnoreBase {
   }
 
   _initCache () {
-    this._cache = {}
+    this._cache = Object.create(null)
   }
 
   // @param {Array.<string>|string|Ignore} pattern

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ignore",
-  "version": "4.0.5",
+  "version": "4.0.6",
   "description": "Ignore is a manager and filter for .gitignore rules.",
   "files": [
     "legacy.js",

diff --git a/test/fixtures/cases.js b/test/fixtures/cases.js
@@ -8,6 +8,20 @@ function readPatterns (file) {
 }
 
 const cases = [
+  [
+    'object prototype',
+    [
+      '*',
+      '!hasOwnProperty',
+      '!a'
+    ],
+    {
+      'hasOwnProperty': 0,
+      'a/hasOwnProperty': 0,
+      'toString': 1,
+      'a/toString': 1
+    }
+  ],
   [
     'a and a/',
     [