Test calling methods on parentheses with binary operators #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
generalmimon
changed the title
|
There has been a effort long ago and relevant branch to do it in more optimal way. Unfortunately, I wasn't very successful with finishing that work, and never got the chance to return to it. I think that this one still works good, at least exposing all these problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the KSC doesn't always wrap expressions in parentheses where neccessary. For instance,
(str_a + str_b).substring(3, 9)generates the same code asstr_a + str_b.substring(3, 9)for most languages. It's low priority, but it's clearly a bug in the compiler and should be fixed.If the bug will take effect or not depends on the actual implementation in the target language, so I think it's wise to add a test for it to see where it works and where not.
kaitai-io/kaitai_struct#69 is related. Simply put, sometimes there are unnecessarily many brackets and sometimes too little. However, unless the compiler is 100% sure that the brackets are useless, it's always better to include them.