Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Features #6

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Additional Features #6

wants to merge 20 commits into from

Conversation

l4rm4nd
Copy link
Contributor

@l4rm4nd l4rm4nd commented Feb 3, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our contribution guidelines
  • This change does not contain any possible security vulnerabilities

What kind of change does this PR introduce?

  • German translation file de.json
  • New input field for opening times of a restaurant

image

image

image

What is the current behavior?

The opening time of a restaurant is defined in the menu itself, which is nice but could be improved. I recommend showing the general opening times too.

What is the new behavior?

  • When creating a new restaurant, we can define the general opening times as string too. Those will be displayed in the restaurant digital menu website beside the other information like location, phone number.
  • The new de.json language file can be used to force German language. Either overwrite the en.json via Docker Volume mappings or if barebone is used, just replace the content of en.json with the content of de.json. Privacy policy and Terms & Conditions not yet translated though.

Does this PR introduce a breaking change?

A new database column is created and required for the Restaurant table. So existing data and MySQL/MariaDB instances won't have this new table. Requires manually adding the table or doing some automatic db migrations

# connect to the mariadb container if docker is used
docker exec -it menufic-db sh

# log into mariadb database
mariadb -u menufic -pmenufic menufic

# add new table
ALTER TABLE Restaurant ADD openingTimes VARCHAR(191) NOT NULL AFTER contactNo;

Copy link

sonarqubecloud bot commented Feb 3, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant