Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config setting no longer true by default #84

Closed
bobbywarner opened this issue Dec 29, 2015 · 4 comments
Closed

Config setting no longer true by default #84

bobbywarner opened this issue Dec 29, 2015 · 4 comments

Comments

@bobbywarner
Copy link

With previous versions of the plugin, you did not have to specify the sequence_per_table config setting and it would default to true. Looks like now you do have to explicitly set it otherwise you get a NPE on this line -- https://github.com/kaleidos/grails-postgresql-extensions/blob/master/src/main/groovy/net/kaleidos/hibernate/PostgresqlExtensionsDialect.java#L60

Caused by: java.lang.ClassCastException: org.grails.config.NavigableMap$NullSafeNavigator cannot be cast to java.lang.Boolean
     at net.kaleidos.hibernate.PostgresqlExtensionsDialect$TableNameSequenceGenerator.configure(PostgresqlExtensionsDialect.java:60) ~[postgresql-extensions-4.6.4.jar:na]
     at org.hibernate.id.factory.internal.DefaultIdentifierGeneratorFactory.createIdentifierGenerator(DefaultIdentifierGeneratorFactory.java:117) ~[hibernate-core-4.3.11.Final.jar:4.3.11.Final]```
@ilopmar
Copy link
Collaborator

ilopmar commented Dec 30, 2015

I've done some tests and it's not a problem of the plugin but something related to Grails. I tried with a very simple project (https://github.com/ilopmar/pg-extensions-grails3-jsonb-example-app) and with Grails 3.0.10 or above the problem exist.
You can clone the project, change the grails version to 3.0.9 with sdk and in gradle.properties and the project starts without problems.

I need to dig into grails source code to see what has changed and then check the values correctly in the plugin.

@bobbywarner
Copy link
Author

@ilopmar Ah, ok. Sounds good. Thanks!

@ilopmar
Copy link
Collaborator

ilopmar commented Dec 31, 2015

It seems that this commit may be related to the change: grails/grails-core@50cf244

@ilopmar
Copy link
Collaborator

ilopmar commented Dec 31, 2015

Fixed in 4.6.5 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants