-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(entry/captions): add delete menu option to broken caption KMCNG-2381 #960
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@viktor-kyryltsev-kaltura while this solution would work, we usually filter the actions menu according to the data in the openActionsMenu function as shown here:
kmc-ng/src/applications/content-entries-app/entry/entry-captions/entry-captions.component.ts
Lines 63 to 81 in 26283af
openActionsMenu(event: any, caption: any): void{ | |
if (!this._requestCaptionsAvailable && this._actions[1].id === 'editor') { | |
this._actions.splice(1,1); | |
} | |
if (this._requestCaptionsAvailable && this._actions[1].id === 'editor') { | |
if (caption.format !== KalturaCaptionType.srt && caption.format !== KalturaCaptionType.dfxp && caption.format !== KalturaCaptionType.webvtt) { | |
this._actions[1].disabled = true; | |
this._actions[1].title = this._appLocalization.get('applications.content.entryDetails.captions.editorDisabled'); | |
} else { | |
this._actions[1].disabled = false; | |
this._actions[1].title = null; | |
} | |
} | |
if (this.actionsMenu){ | |
// save the selected caption for usage in the actions menu | |
this._widgetService.currentCaption = caption; | |
this.actionsMenu.toggle(event); | |
} | |
} |
Lets use the same logic here as well.
* Upgrade to Angular 10.2 * primeng style fixes * update primeng styles * update primeng styles * update primeng styles * update primeng styles * update primeng styles * update primeng styles * update primeng styles * update primeng autocomplete * update primeng styles * update primeng styles * update primeng styles * update primeng styles * update primeng styles * update primeng styles * update primeng styles * update primeng styles * upgrade to Angular 11 * add import statement * Angular 11 upgrade - style fixes and Auto-complete API changes * Angular 11 upgrade - style fixes * Angular 11 upgrade - radio box in reactive form fix for issue primefaces/primeng#9631 * Angular 11 upgrade - style fix * Angular 11 upgrade - style fixs * Angular 11 RxJs fixes * Angular 11 RxJs fixes * Angular 11 RxJs fixes * Angular 11 RxJs fixes * Angular 11 RxJs fixes * Angular 11 RxJs fixes * Angular 11 RxJs fixes * Angular 11 fixes after master merge * update kaltura-ng libs * update clientlib * typo fix * fix(live stream): change universal live call to use new RxJS syntax (#945) * fix(entries/categories): endless load of Entitlements tab (use new RxJS syntax) (#946) * fix(playlists/details): switch to next/previous playlist (left/right arrows) (#949) * fix(settings/transcoding): table has wrong width on IE11 (#950) * typo fix * fix(entries/edit/flavors/): Match from Drop Folder error due to old RxJS syntax (use new RxJS syntax) (#947) * fix(categories): After selecting another Category all of them disappear on Move Category (#952) * fix(entry): IE-11 - Back arrow cut-off in all relevant pages KMCNG-2340 (#948) * fix(entries/edit): IE-11 - Back arrow cut-off in all relevant pages * fix(entry): back button is cut-off in IE11 * fix(entries/distribution): refresh button is cut off KMCNG-2320 (#951) * fix(entries/distribution): refresh button is cut off * fix(entry/distribution): IE11 - refresh button is cut off * fix: angular.json * fix(theme): change controls color to primary, change analytics logo, change header gradient KMCNG-2370 (#953) * fix(theme): change controls color to primary, change analytics logo, change header gradient * fix: link colors, logo for dpi 1 * fix(theme): style and RxJS fixes for Angular 11 (#954) * fix(settings/integration): fix zoom form radio controls * chore: update kaltura libraries * fix(playlists/rule based playlist): fix RxJS old syntax issues (#956) * fix(login/expired password): add validation for new password to be different than old KMCNG-2377 (#958) * fix(login/expired password): add validation for new password to be different than old * fix: show new password equality error message at the bottom * fix(upload/manual-live): add support for DASH stream KMCNG-2376 (#957) * fix(upload/manual-live): add support for DASH stream * fix: add DASH to error message * fix(settings/integration): zoom - copy code without break lines (#961) * fix(entry/captions): add delete menu option to broken caption KMCNG-2381 (#960) * fix(entry/captions): add delete menu option to broken caption * fix: move actions filtering logic Co-authored-by: Viktor Kyryltsev <[email protected]>
PR information
What is the current behavior?
What is the new behavior?
Does this PR introduce a breaking change?