Adding initial page feature #8
Conversation
| }); | ||
|
|
||
| $scope.goTo = function(index){ | ||
| setTimeout(function() { |
There was a problem hiding this comment.
Why is setTimeout needed here? maybe $scope.$$postDigest would be enough if any delay of execution at all. What happens if the setTimeout is removed?
There was a problem hiding this comment.
All right, $$postDigest might solve the problem, it was just a hacky setTimeout Zero just to run scrollTop after content loaded, waiting all DOM negotiation finishes before scrollTop, or parent height would be 0px.
I'll note this as many others under the hood and not documented useful angular features found.
…ll height checkiing if sizesPropertyExist, all noted from original author (@kamilkp)
| var scrollPosition = (sizesPropertyExists) ? | ||
| ($scope.sizesCumulative[index] + $scope.offsetBefore): | ||
| (index * $scope.elementSize + $scope.offsetBefore); | ||
| $scrollParent[0].scrollTop = scrollPosition; |
There was a problem hiding this comment.
One more thing. This assumes that we are using vertically stacked element. Whereas vs-repeat also supports scrolling horizontally. Instead of referencing scrollTop use the scrollPos variable that i declare in the linking function.
Hi there,
I work at Lumis [http://www.lumis.com.br] and here we'll start to use a fork of your code to our publications viewer app, whose nickname is Poligno. We found useful to set an initial scroll to an element, so I'm sending you this pull request to thank you for your code and collaborate too.
Best regards,
=P