Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use class instead of direct element color override for nav icon state #73

Closed
chron0 opened this issue Nov 5, 2017 · 4 comments
Closed
Labels

Comments

@chron0
Copy link

chron0 commented Nov 5, 2017

Currently the icon gets a direct element color override of color: rgb(0, 255, 0);
That interferes with other themes efforts to keep a consistent color matching scheme.

Could we use an "active" class, which can be overridden by themes?

@kantlivelong
Copy link
Owner

I've committed this to a new branch. Would anyone be willing to give it a test?

@chron0
Copy link
Author

chron0 commented Nov 8, 2017

Sure, if no one else beats me to it, I'll try it the coming weekend. And if it works, I'll also directly build the css updates into DarkMatter Theme, so it'll work with it straight away.

@kantlivelong
Copy link
Owner

I tested this with a modified TouchUI (PR pending) and it looks good here. Will merge into devel soon.

@kantlivelong
Copy link
Owner

Tested again with modified Cyborg theme. Merged into devel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants