-
-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config rework #2108
Config rework #2108
Conversation
oh I also added a |
I couldn't run all specs locally. There are a couple that failed where I changed the spec. In particular, it was testing that if it set |
Signed-off-by: Maciej Mensfeld <[email protected]>
retargeting and merging to a work-branch |
This isn't finished yet. The idea here is to use
:not_given
as all config parameters, construct the config proactively, and only consider it a "read" operation if no parameters are given at all.periodic_job is a bit more in-depth, so I'm leaving off on it for now - I just wanted to validate this approach first and get feedback. Also not sure if there's additional configuration I'm not aware of, I was looking at the topic stuff.
The main advantage here is the ability to make changes to individual parts of each config rather than blowing away the whole thing at once. It also opens up the ability to redefine / reconfigure things dynamically if needed - right now, you can only configure any feature once, either by explicit setting or by default, and never again.
@mensfeld