Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use libusb 1.0.27 as backend on linux #50

Merged
merged 6 commits into from
Feb 9, 2024
Merged

use libusb 1.0.27 as backend on linux #50

merged 6 commits into from
Feb 9, 2024

Conversation

holiman
Copy link
Collaborator

@holiman holiman commented Feb 9, 2024

This PR adds back libusb (version 1.0.27 at commit libusb/libusb@d52e355) for linux, to avoid the requirement of libudev being present on the target.

Todo:

  • Verify that ledgers are still detected properly

Geth with this PR:

INFO [02-09|11:03:13.477] New wallet appeared                      url=ledger://1-1:1.0 status="Ethereum app v1.9.19 online"

@holiman
Copy link
Collaborator Author

holiman commented Feb 9, 2024

With this PR:

[user@work hid]$ go run ./demo.go 
hid.Supported() true
--------------------------------------------------------------------------------------------------------------------------------
HID #0
  OS Path:      1-1:1.0
  Vendor ID:    0x2c97
  Product ID:   0x5015
  Release:      513
  Serial:       
  Manufacturer: 
  Product:      
  Usage Page:   0x0000
  Usage:        0
  Interface:    0
--------------------------------------------------------------------------------------------------------------------------------
HID #1
  OS Path:      1-1:1.1
  Vendor ID:    0x2c97
  Product ID:   0x5015
  Release:      513
  Serial:       
  Manufacturer: 
  Product:      
  Usage Page:   0x0000
  Usage:        0
  Interface:    1
================================================================================================================================

With master

[user@work hid]$ go run ./demo.go 
hid.Supported() true
--------------------------------------------------------------------------------------------------------------------------------
HID #0
  OS Path:      /dev/hidraw0
  Vendor ID:    0x2c97
  Product ID:   0x5015
  Release:      513
  Serial:       0001
  Manufacturer: Ledger
  Product:      Nano S Plus
  Usage Page:   0xffa0
  Usage:        1
  Interface:    0
--------------------------------------------------------------------------------------------------------------------------------
HID #1
  OS Path:      /dev/hidraw1
  Vendor ID:    0x2c97
  Product ID:   0x5015
  Release:      513
  Serial:       0001
  Manufacturer: Ledger
  Product:      Nano S Plus
  Usage Page:   0xf1d0
  Usage:        1
  Interface:    1
================================================================================================================================

@holiman holiman changed the title Add libusb use libusb 1.0.27 as backend on linux Feb 9, 2024
@holiman holiman merged commit d3b59fe into master Feb 9, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant