Skip to content
This repository has been archived by the owner on Jul 29, 2022. It is now read-only.

Update README.md #31

Closed
wants to merge 1 commit into from
Closed

Conversation

andyhasit
Copy link

Updated README to show wrapping of done in a function.
This. solves issues like this: Swiip/generator-gulp-angular#498

Updated README to show wrapping of done in a function.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@pkozlowski-opensource
Copy link
Member

This is not a correct change, see #18 for more details.

@andyhasit
Copy link
Author

Indeed, I hadn't thought about that, though am aware of the issue of CI relying on proper return codes. I suppose this makes my suggestion a hack for personal use cases, and therefore doesn't belong in the README.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants