This repository has been archived by the owner on Sep 7, 2022. It is now read-only.
fix: karma doesn't kill PhantomJS on windows when using singleRun:true #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I hit #27 on Windows 8.1, x64, this solves the issue for me 👍 |
| var isWin = /^win/.test(process.platform); | ||
| if (isWin) { | ||
| flags = flags.concat(win32PhantomJSPath(), captureFile); | ||
| } |
There was a problem hiding this comment.
little style thing:
} else {please
|
Some small styling issues other than that lgtm. |
Now returns the node.exe process that runs phantom instead of the phantomjs.cmd process Closes karma-runner#27
|
@dignifiedquire ok now? |
|
👍 |
sylvain-hamel
added a commit
that referenced
this pull request
Apr 1, 2014
fix: karma doesn't kill PhantomJS on windows when using singleRun:true
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now returns the node.exe process that runs phantom instead of the phantomjs.cmd process
Closes #27