chore: Switch to a maintained Markdown parser #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namp is [archived](https://github.com/gjtorikian/namp). So switching to a more maintained and feature-rich Markdown parser. This is a preparation for implementing karma-runner#47. Had to put metadata between `--- ---` (Jekyll syntax) as the previous syntax was not supported by the new Markdown parser. Separate PR to land the same changes in the Karma repository is coming. Besides the above, the output is pretty much the same. Only minor escaping/whitespace changes in the rendered website + a couple of pieces of text, which were missed because of the bug in the old markdown parser.
devoto13
added a commit
to devoto13/karma
that referenced
this pull request
Apr 10, 2021
johnjbarton
pushed a commit
to karma-runner/karma
that referenced
this pull request
Apr 12, 2021
…3672) Companion PR for karma-runner/karma-runner.github.com#62. * docs: fix invalid heading syntax It is not recognized as a heading by the markdown parser without a whitespace. * docs: fix weird syntax to reduce diff Old parser considered this the same list, but new parser assumes that these are two separate lists. Technically it should be a nested list, but it is old and shouldn't really matter. I'm doing this change to reduce the diff I need to review after switching to the new markdown parser. * docs: fix invalid markdown Items nested in the list item, must be indented 3 spaces, not 2 spaces. New parser produced a pretty messed up markup from the invalid markdown. * docs: remove redundant whitespaces in the list items
anthony-redFox
pushed a commit
to anthony-redFox/karma
that referenced
this pull request
May 16, 2023
…arma-runner#3672) Companion PR for karma-runner/karma-runner.github.com#62. * docs: fix invalid heading syntax It is not recognized as a heading by the markdown parser without a whitespace. * docs: fix weird syntax to reduce diff Old parser considered this the same list, but new parser assumes that these are two separate lists. Technically it should be a nested list, but it is old and shouldn't really matter. I'm doing this change to reduce the diff I need to review after switching to the new markdown parser. * docs: fix invalid markdown Items nested in the list item, must be indented 3 spaces, not 2 spaces. New parser produced a pretty messed up markup from the invalid markdown. * docs: remove redundant whitespaces in the list items
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
namp is archived. So switching to a more maintained and feature-rich Markdown parser. This is a preparation for implementing #47.
Had to put metadata between
--- ---(Jekyll syntax) as the previous syntax was not supported by the new Markdown parser. Separate PR to land the same changes in the Karma repository is coming.Besides the above, the output is pretty much the same. Only minor escaping/whitespace changes in the rendered website + a couple of pieces of text, which were missed because of the bug in the old markdown parser.