Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launching 10 instances of safari when one would do #6

Open
Dakuan opened this issue Oct 31, 2013 · 15 comments
Open

Launching 10 instances of safari when one would do #6

Dakuan opened this issue Oct 31, 2013 · 15 comments

Comments

@Dakuan
Copy link

Dakuan commented Oct 31, 2013

Since installing Mavericks, Karma has got very keen on Safari, and launches 10 instances. Additionally, it doesn't close them after the tests have executed. I have to manually close one of the tabs, and then they all go. Super odd!

image

@lennym
Copy link

lennym commented Nov 1, 2013

This isn't isolated to Mavericks. I've had similar issues on Mountain Lion. It seems that when opening a new Safari instance, previous runs of karma are present in the old tabs which are also opened, and seem to restart.

One thing I've done that seems to have helped is changing my Safari preferences to always open new windows and tabs with an empty page (Preferences>General).

@dfreedm
Copy link

dfreedm commented Nov 14, 2013

I've had success with defaults write com.apple.Safari ApplePersistenceIgnoreState YES on Mavericks

@easternbloc
Copy link

thanks @azakus that totally worked for me on Mavericks :)

@Dakuan
Copy link
Author

Dakuan commented Nov 20, 2013

ditto!

On 20 November 2013 17:40, Ben Marvell [email protected] wrote:

thanks @azakus https://github.com/azakus that totally worked for me on
Mavericks :)


Reply to this email directly or view it on GitHubhttps://github.com//issues/6#issuecomment-28910975
.

// Dominic Barker //
github http://dakuan.github.com |
linkedInhttp://www.linkedin.com/profile/view?id=87278307&trk=tab_pro
| twitter http://twitter.com/#!/mostlyharmlessd |
google+https://plus.google.com/116981867908651073843/posts

@FoxGit
Copy link

FoxGit commented Feb 6, 2014

Does not work for me unfortunately. Ever time I run Karma a new Tab is added. I tried both the solutions of @lennym and @azakus. Strangely enough the safari opens up with a clean new page without the old tabs if I open it manually. But opened again with Karma it starts with oldTabsNumber + 1. Any further ideas? :(

@vojtajina
Copy link
Contributor

This should fix it karma-runner/karma#878

@lazd
Copy link

lazd commented Feb 20, 2014

I can confirm @azakus's workaround works on OS X 10.9.1 with Safari 7.0.1.

@thebigredgeek
Copy link

Can you elaborate on how to fix this? Still having issues with it and I don't know what the above mentioned fix is referring to. Thanks

@thebigredgeek
Copy link

Ah! NVM! Just a CLI routine. Haha

@zedd45
Copy link

zedd45 commented Apr 24, 2014

So far, the solution @azakus supplied seems to be working for me. Thanks!

@gardenvarietyse
Copy link

A small hack that seems to work, but has definitely not been extensively tested: gardenvarietyse/karma-safari-launcher@28eb4f19737af74037cb5cf17160f9770172bbd1

@dignifiedquire
Copy link
Member

@gardenvarietyse Would you like to make a PR out of your hack that gets triggered with a custom option forceKill for the safari launcher? I think this would be very helpful until we fix the underlying karma issue.

@Keysox
Copy link

Keysox commented Aug 10, 2015

Thanks @azakus - that works for me on Yosemite

@rhewitt22
Copy link

@azakus - worked on El Capitan 👍

@mgol
Copy link

mgol commented Feb 1, 2017

See #20.

RLovelett added a commit to RLovelett/karma-safari-launcher that referenced this issue Mar 3, 2017
For all the reasons addressed in a WebKit blog post,
https://webkit.org/blog/6901/webdriver-support-in-safari-10/,
this method should be preferred over the previous method.

This should address the concerns of both karma-runner#6 and karma-runner#20.
RLovelett added a commit to RLovelett/karma-safari-launcher that referenced this issue Mar 3, 2017
For all the reasons addressed in a WebKit blog post,
https://webkit.org/blog/6901/webdriver-support-in-safari-10/,
this method should be preferred over the previous method.

This should address the concerns of both karma-runner#6 and karma-runner#20.
RLovelett added a commit to RLovelett/karma-safari-launcher that referenced this issue Mar 3, 2017
For all the reasons addressed in a WebKit blog post,
https://webkit.org/blog/6901/webdriver-support-in-safari-10/,
this method should be preferred over the previous method.

This should address the concerns of both karma-runner#6 and karma-runner#20.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests