-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Launching 10 instances of safari when one would do #6
Comments
This isn't isolated to Mavericks. I've had similar issues on Mountain Lion. It seems that when opening a new Safari instance, previous runs of karma are present in the old tabs which are also opened, and seem to restart. One thing I've done that seems to have helped is changing my Safari preferences to always open new windows and tabs with an empty page (Preferences>General). |
I've had success with |
thanks @azakus that totally worked for me on Mavericks :) |
ditto! On 20 November 2013 17:40, Ben Marvell [email protected] wrote:
// Dominic Barker // |
Does not work for me unfortunately. Ever time I run Karma a new Tab is added. I tried both the solutions of @lennym and @azakus. Strangely enough the safari opens up with a clean new page without the old tabs if I open it manually. But opened again with Karma it starts with oldTabsNumber + 1. Any further ideas? :( |
This should fix it karma-runner/karma#878 |
I can confirm @azakus's workaround works on OS X 10.9.1 with Safari 7.0.1. |
Can you elaborate on how to fix this? Still having issues with it and I don't know what the above mentioned fix is referring to. Thanks |
Ah! NVM! Just a CLI routine. Haha |
So far, the solution @azakus supplied seems to be working for me. Thanks! |
A small hack that seems to work, but has definitely not been extensively tested: gardenvarietyse/karma-safari-launcher@28eb4f19737af74037cb5cf17160f9770172bbd1 |
@gardenvarietyse Would you like to make a PR out of your hack that gets triggered with a custom option |
Thanks @azakus - that works for me on Yosemite |
@azakus - worked on El Capitan 👍 |
See #20. |
For all the reasons addressed in a WebKit blog post, https://webkit.org/blog/6901/webdriver-support-in-safari-10/, this method should be preferred over the previous method. This should address the concerns of both karma-runner#6 and karma-runner#20.
For all the reasons addressed in a WebKit blog post, https://webkit.org/blog/6901/webdriver-support-in-safari-10/, this method should be preferred over the previous method. This should address the concerns of both karma-runner#6 and karma-runner#20.
For all the reasons addressed in a WebKit blog post, https://webkit.org/blog/6901/webdriver-support-in-safari-10/, this method should be preferred over the previous method. This should address the concerns of both karma-runner#6 and karma-runner#20.
Since installing Mavericks, Karma has got very keen on Safari, and launches 10 instances. Additionally, it doesn't close them after the tests have executed. I have to manually close one of the tabs, and then they all go. Super odd!
The text was updated successfully, but these errors were encountered: