fix(launcher): cancel kill timeout when process exits cleanly #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -110,6 +110,10 @@ var ProcessLauncher = function(spawn, tempDir, timer) { | |||
| } | |||
|
|
|||
| self._process = null; | |||
| if (self._killTimer) { | |||
| timer.clearTimeout(self._killTimer); | |||
| self._killTimer = undefined; | |||
There was a problem hiding this comment.
Can you please set this to null ?
There was a problem hiding this comment.
Can you please set this to
null?
Why is null better than undefined here?
By default browsers are killed with `process.kill()` but it might happen that a process doesn't play nicelly and doesn't exit so there is a timeout after which a process is SIGKILL-ed. Before this commit the mentioned timeout wasn't cleared on clean process exit, preventing Karma from exiting just after all tests were run. Fixes karma-runner#946
|
@vojtajina amended the commit to use |
|
Merging... |
bendrucker
added a commit
to bendrucker/karma-as-promised
that referenced
this pull request
Jun 18, 2014
Hangs were fixed in 0.12.15/16 karma-runner/karma#1040 karma-runner/karma#1054
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default browsers are killed with
process.kill()but it mighthappen that a process doesn't play nicelly and doesn't exit so
there is a timeout after which a process is SIGKILL-ed. Before
this commit the mentioned timeout wasn't cleared on clean process
exit, preventing Karma from exiting just after all tests were run.
Fixes #946