-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: fix dependabot can not access the secrets #4762
Conversation
/assign @RainbowMango |
3a85902
to
8a187eb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4762 +/- ##
==========================================
- Coverage 51.79% 51.76% -0.04%
==========================================
Files 250 250
Lines 24991 24982 -9
==========================================
- Hits 12945 12932 -13
- Misses 11337 11341 +4
Partials 709 709
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
74ecb00
to
4998713
Compare
I found the PR for this warnning log and seems like it just wanted to draw people's attention to the fact that this requires write permissions. So just add permission for this workflow to resolve it, keeping on push event to trigger it. PTAL,Thanks. |
And it's verifyed on my fork repo, check https://github.com/liangyuanpeng/karmada/actions/runs/8518835905/job/23331711824?pr=53 |
@liangyuanpeng Thanks for your work! This warning log is indeed very confusing. Since it's just a permissions issue, I think your change is appropriate. |
Co-authored-by: zhzhuang-zju <[email protected]> Co-authored-by: RainbowMango <[email protected]> Signed-off-by: Lan Liang <[email protected]>
4998713
to
b825b35
Compare
PTAL,Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
PartOf #4761
skip the push event for dependabot
Which issue(s) this PR fixes:
Fixes #4761
Special notes for your reviewer:
Does this PR introduce a user-facing change?: