Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix dependabot can not access the secrets #4762

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

liangyuanpeng
Copy link
Contributor

@liangyuanpeng liangyuanpeng commented Mar 28, 2024

What type of PR is this?

/kind cleanup
What this PR does / why we need it:

PartOf #4761

skip the push event for dependabot

Which issue(s) this PR fixes:
Fixes #4761

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Mar 28, 2024
@liangyuanpeng
Copy link
Contributor Author

/assign @RainbowMango

@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 28, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.76%. Comparing base (ff7322a) to head (b825b35).
Report is 38 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4762      +/-   ##
==========================================
- Coverage   51.79%   51.76%   -0.04%     
==========================================
  Files         250      250              
  Lines       24991    24982       -9     
==========================================
- Hits        12945    12932      -13     
- Misses      11337    11341       +4     
  Partials      709      709              
Flag Coverage Δ
unittests 51.76% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liangyuanpeng liangyuanpeng force-pushed the fix_dependabot branch 2 times, most recently from 74ecb00 to 4998713 Compare April 2, 2024 07:47
@liangyuanpeng liangyuanpeng changed the title ci: let trivy image scan working on pull_request for dependabot. ci: fix dependabot can not access the secrets Apr 2, 2024
@liangyuanpeng
Copy link
Contributor Author

github/codeql-action#435 (comment)
Although perhaps you could add "Uploading code scanning results requires write access." as second sentence?

I found the PR for this warnning log and seems like it just wanted to draw people's attention to the fact that this requires write permissions.

So just add permission for this workflow to resolve it, keeping on push event to trigger it.

PTAL,Thanks.
/cc zhzhuang-zju @RainbowMango

@liangyuanpeng
Copy link
Contributor Author

@zhzhuang-zju
Copy link
Contributor

I found the PR for this warnning log and seems like it just wanted to draw people's attention to the fact that this requires write permissions.

@liangyuanpeng Thanks for your work! This warning log is indeed very confusing. Since it's just a permissions issue, I think your change is appropriate.

Co-authored-by: zhzhuang-zju <[email protected]>
Co-authored-by: RainbowMango <[email protected]>
Signed-off-by: Lan Liang <[email protected]>
@karmada-bot karmada-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 9, 2024
@liangyuanpeng
Copy link
Contributor Author

PTAL,Thanks.

@RainbowMango @zhzhuang-zju

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2024
@karmada-bot karmada-bot merged commit feb2437 into karmada-io:master Apr 9, 2024
12 checks passed
@pulsarsigs-bot pulsarsigs-bot deleted the fix_dependabot branch April 9, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependabot can not access the secrets
5 participants