Conv and ConvFloat conversion traits, i32 in Size, new Offset type, fn extract #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rationale: this avoids a lot of casts in user-code, also allowing more unified code (approx 350 lines simplified). Cost: extra casts in windowing code (approx 150 lines). Also approx 1300 lines simply replacing u32 with i32.
Let Coord be a position, not a vector from the origin. Let Size be a vector between two positions. This saves all conversions between Size and Coord (save one due to winit).
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces most uses of
asfor type-casting with new conversion traits, with accuracy checks at least during debug mode. (Possibly these traits should be spun off into a new crate.)The
Sizetype now usesi32instead ofu32to avoid converting everywhere.Sizewas made a vector type, then vector uses were replaced with a newOffsettype so thatSizecan check values are non-negative at least sometimes.Also fixes some missing redraws.