Shortcuts: extend, add specific MacOS shortcuts; rename ControlKey → Command #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These shortcuts are mostly inferred from documentation of standard shortcuts on OSX and Windows 10.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MacOS and Windows should now have most of the right shortcuts for text-editing, plus a bunch more (currently unused). There's currently no differentiation between Linux (KDE, Gnome, ...) and Windows and no direct consideration for anything else — probably testing and feedback is needed.
Run-time and application-specific configuration is obviously needed and being planned.
Some system for handling global shortcuts is also required — e.g. whether
Exit(Ctrl+Q on most platforms) closes the app immediately or prompts or does nothing (current behaviour).This PR also moves direction and alignment types to tidy up the top-level API.
Edit: also added
CastandCastFloattraits.