Config read/write support #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds working read & write support for shortcut configuration.
JSON and YAML support are included. TOML is not because the
tomlcrate does not support enums as map keys and I don't see another TOML+Serde crate.Adjusts
kas_wgpu::Options, adding two env vars controlling behaviour.Some cleanup is needed before merge, but otherwise I think this is good for now. The file format is unstable and until that changes, there won't be a default config path, though later there should be (using the
directoriescrate or similar).TODO: cleanup commits, better documentation?Edit: done cleanup; serde is now optional.