Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#505 #473 Upgrade kaspa-alloc's mimalloc dependency #519

Merged
merged 2 commits into from
Aug 19, 2024
Merged

#505 #473 Upgrade kaspa-alloc's mimalloc dependency #519

merged 2 commits into from
Aug 19, 2024

Conversation

saefstroem
Copy link
Collaborator

@saefstroem saefstroem commented Aug 15, 2024

What is this
This PR closes #505, #473.

How
By upgrading the mimalloc dependency to version 0.1.43 which uses version 2.1.7 version of mimalloc.

Tests performed
Problems specified in #473 were resolved through a manual test by @blackmennewstyle.

Why do we need it

kaspa-alloc uses an outdated dependency of mimalloc rust crate 0.1.39 which uses the 2.1.2 version of the mimalloc impl by Microsoft.

In this outdated dependency there is a problem of compilation on some systems: microsoft/mimalloc#883

This is fixed in a later version of mimalloc hence the reason for why we need to upgrade the dependency in the kaspa-alloc crate.

Upgrade mimalloc to 0.1.43 implementing the fix by microsoft team.
@saefstroem saefstroem marked this pull request as ready for review August 18, 2024 13:21
@saefstroem
Copy link
Collaborator Author

@michaelsutton @aspect

@michaelsutton michaelsutton merged commit e6e0f58 into kaspanet:dev Aug 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

‘__builtin_thread_pointer’ is not supported on this target
2 participants