This repository has been archived by the owner on May 12, 2021. It is now read-only.
network: Don't remove the network routes when destroying the sandbox #230
Comments
sboeuf
pushed a commit
to sboeuf/agent
that referenced
this issue
Apr 27, 2018
The only case where we might want to get rid of the entire network inside the VM is when we're about to destroy the sandbox, therefore the VM. There is no reason to bother doing this ourselves and we can instead leave this task to the VM itself when it gets shutdown. This commit simplifies what we have to handle since there is no real benefits in tearing down the network from the agent. Fixes kata-containers#230 Signed-off-by: Sebastien Boeuf <[email protected]>
sboeuf
pushed a commit
to sboeuf/agent
that referenced
this issue
Apr 27, 2018
The only case where we might want to get rid of the entire network inside the VM is when we're about to destroy the sandbox, therefore the VM. There is no reason to bother doing this ourselves and we can instead leave this task to the VM itself when it gets shutdown. This commit simplifies what we have to handle since there is no real benefits in tearing down the network from the agent. Fixes kata-containers#230 Signed-off-by: Sebastien Boeuf <[email protected]>
sboeuf
pushed a commit
to sboeuf/agent
that referenced
this issue
Apr 30, 2018
The only case where we might want to get rid of the entire network inside the VM is when we're about to destroy the sandbox, therefore the VM. There is no reason to bother doing this ourselves and we can instead leave this task to the VM itself when it gets shutdown. This commit simplifies what we have to handle since there is no real benefits in tearing down the network from the agent. Fixes kata-containers#230 Signed-off-by: Sebastien Boeuf <[email protected]>
sboeuf
changed the title
sboeuf
pushed a commit
to sboeuf/agent
that referenced
this issue
Apr 30, 2018
The network routes will always be removed when the associated interfaces are going to be removed. It is safer to leave this to each interface removal. Fixes kata-containers#230 Signed-off-by: Sebastien Boeuf <[email protected]>
sboeuf
pushed a commit
to sboeuf/agent
that referenced
this issue
Apr 30, 2018
The network routes will always be removed when the associated interfaces are going to be removed. Same thing for DNS. It is safer to leave this to each interface removal. Fixes kata-containers#230 Signed-off-by: Sebastien Boeuf <[email protected]>
sboeuf
pushed a commit
to sboeuf/agent
that referenced
this issue
May 1, 2018
The network routes will always be removed when the associated interfaces are going to be removed. Same thing for DNS. It is safer to leave this to each interface removal. Fixes kata-containers#230 Signed-off-by: Sebastien Boeuf <[email protected]>
sboeuf
pushed a commit
to sboeuf/agent
that referenced
this issue
May 1, 2018
The network routes will always be removed when the associated interfaces are going to be removed. Same thing for DNS. It is safer to leave this to each interface removal. Fixes kata-containers#230 Signed-off-by: Sebastien Boeuf <[email protected]>
jshachm
pushed a commit
to jshachm/agent
that referenced
this issue
Nov 22, 2018
The network routes will always be removed when the associated interfaces are going to be removed. Same thing for DNS. It is safer to leave this to each interface removal. Fixes kata-containers#230 Signed-off-by: Sebastien Boeuf <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The network routes will always be removed when the associated interfaces are going to be removed. It is safer to leave this to each interface removal.
The text was updated successfully, but these errors were encountered: