Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update contributor guide with more re-vendor details #88

Closed
jodh-intel opened this issue Mar 6, 2019 · 0 comments
Closed

Update contributor guide with more re-vendor details #88

jodh-intel opened this issue Mar 6, 2019 · 0 comments
Assignees
@jodh-intel

Comments

@jodh-intel
Copy link
Contributor

The contributor guide needs to state that a git add vendor/ is required after a dep ensure.

See: kata-containers/runtime#1152 (comment).
@jodh-intel jodh-intel self-assigned this Mar 6, 2019
jodh-intel added a commit to jodh-intel/community that referenced this issue Mar 6, 2019
@jodh-intel
docs: Add more vendor details to contributing guide
1deb27d 
Explain that it is necessary to `git add vendor/` after running `dep
ensure`.

Fixes kata-containers#88.

Signed-off-by: James O. D. Hunt <[email protected]>
@jodh-intel jodh-intel mentioned this issue Mar 6, 2019
Merged
@devimc devimc closed this as completed in #89 Mar 6, 2019
@umarcor umarcor mentioned this issue Mar 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jodh-intel jodh-intel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jodh-intel