Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add more vendor details to contributing guide #89

Merged

Conversation

jodh-intel
Copy link
Contributor

Explain that it is necessary to git add vendor/ after running dep ensure.

Fixes #88.

Signed-off-by: James O. D. Hunt [email protected]

Explain that it is necessary to `git add vendor/` after running `dep
ensure`.

Fixes kata-containers#88.

Signed-off-by: James O. D. Hunt <[email protected]>
Copy link
Contributor

@grahamwhaley grahamwhaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@grahamwhaley grahamwhaley requested a review from sboeuf March 6, 2019 10:56
@devimc
Copy link

devimc commented Mar 6, 2019

Thanks @jodh-intel

@devimc devimc merged commit 47413c3 into kata-containers:master Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants