This repository has been archived by the owner on May 12, 2021. It is now read-only.
virtcontainers: inherit parent's CPU constraint #1569
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't set a default CPU constraint if period and quota are not specified, that way the container will inherit the CPU constraint from its parent. Container creation won't fail if the parent CPU constraint is smaller than the default number of vCPUs. fixes kata-containers#1521 Signed-off-by: Julio Montes <[email protected]> (cherry picked from commit 59e3956) Signed-off-by: Ganesh Maharaj Mahalingam <[email protected]>
amshinde
approved these changes
Apr 19, 2019
|
/test |
egernst
approved these changes
Apr 19, 2019
devimc
approved these changes
Apr 22, 2019
jodh-intel
approved these changes
May 2, 2019
|
/retest |
|
Kindly ignore this PR. I thought I closed it out but seems not. This has been rolled into the big back porting PR for stable 1.6 |
|
@ganeshmaharaj - np, but can we just close it then? |
|
@jodh-intel yes, we should be able to close it now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't set a default CPU constraint if period and quota are not specified, that
way the container will inherit the CPU constraint from its parent. Container
creation won't fail if the parent CPU constraint is smaller than the default
number of vCPUs.
fixes #1521
Signed-off-by: Julio Montes [email protected]
(cherry picked from commit 59e3956)
Signed-off-by: Ganesh Maharaj Mahalingam [email protected]