Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

Use the HEAD or last version of software introduced too much issues #1349

Closed
teawater opened this issue Mar 25, 2019 · 1 comment
Closed

Comments

@teawater
Copy link
Member

#1345
#1343
#1344

The root causes of them use the HEAD or last version of some software that will output different test result or cannot work at all.
Because the HEAD of software means that maybe it can work but actually I am not sure. It just for the developer of this software.
And the behavior of the last version of a software is always different from the previous version even if the Linux kernel.

So I think we should use a special version or commit of the software. If someone wants to change the version, post a PR for it.

teawater added a commit to teawater/runtime that referenced this issue Mar 25, 2019
According what I said in kata-containers/tests#1349,
use the last verion is not a good choice.
This commit set it to 2.3.0.

Fixes: kata-containers#1411

Signed-off-by: Hui Zhu <[email protected]>
@jodh-intel
Copy link
Contributor

Hi @teawater - I'm not quite clear what you are saying here. Do you mean we should be using something like the last/previous releases of yq and the linters to ensure they work on the HEAD of the Kata repos? If so, we could do that by adding details for those external tools to either the main versions database:

... or the additional tests one:

In fact, looking at the main one @ganeshmaharaj, it still mentions gometalinter:

Any chance you could raise a PR to zap that and maybe replace with details for the new linter?

teawater added a commit to teawater/runtime that referenced this issue Mar 27, 2019
According what I said in kata-containers/tests#1349,
use the last verion is not a good choice.
This commit set it to 2.3.0.

Fixes: kata-containers#1411

Signed-off-by: Hui Zhu <[email protected]>
teawater added a commit to teawater/runtime that referenced this issue Apr 2, 2019
According what I said in kata-containers/tests#1349,
use the last verion is not a good choice.
This commit set it to 2.3.0.

Fixes: kata-containers#1411

Signed-off-by: Hui Zhu <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants